Skip to content

Fix IDB interface#127

Open
chuanqisun wants to merge 1 commit into
isomorphic-git:mainfrom
chuanqisun:main
Open

Fix IDB interface#127
chuanqisun wants to merge 1 commit into
isomorphic-git:mainfrom
chuanqisun:main

Conversation

@chuanqisun

@chuanqisun chuanqisun commented Jun 15, 2024

Copy link
Copy Markdown

Fixing #126

  1. Removed the constructor(...) method from the interface. When user provides a custom db instance, the constructor is never invoked by the lightning-fs so constraining it in the interface is unnecessary. Please confirm this though. In addition, if we want to constrain the constructor interface, (for whatever reason), a different setup is required. See: https://stackoverflow.com/questions/13407036/how-does-interfaces-with-construct-signatures-work
  2. Renamed loadFile to readFile, matching implemention.

@jcubic

jcubic commented Jun 16, 2024

Copy link
Copy Markdown
Member

Thanks for the PR, unfortunately I'm not able to merge because test are failing, and I don't know how to fix them.

@chuanqisun

chuanqisun commented Jun 16, 2024

Copy link
Copy Markdown
Author

I just saw your bug report for karma-sauce-launcher. It should be the same issue. Just added additional info others to help debug:

  1. The failing test was a headless browser test that is supposed to run on Edge v79 on a remote testing service provider (SauceLab).
  2. The failure appeared to be a network issue. The remote testing service (SauceLab) refused our network connection, we have retried twice and still no connection. The actual test was never run.
  3. Tests against other browsers all passed.
  4. Because the issue is not related to my change, any future PRs might be blocked by the same issue.

@jcubic

jcubic commented Mar 8, 2025

Copy link
Copy Markdown
Member

I tried to push to force re-run the tests. But it seems that you didn't allow edits to your PR.

@chuanqisun

Copy link
Copy Markdown
Author

I'm sorry, I've already checked the "Allow edits" box. Is there something else I can do to unblock you?
image

@jcubic

jcubic commented Mar 10, 2025

Copy link
Copy Markdown
Member

I'm not sure, I can't push:

 ! [remote rejected] chuanqisun/main -> chuanqisun/main (permission denied)
error: failed to push some refs to 'github.com:chuanqisun/lightning-fs.git'

Maybe I do something wrong, or maybe because you use the main branch.

Can you run?

git rebase -i 9eb71923ed02a2f23d81194feb9e99ef713f5f1b

To change the hash and force push?

@chuanqisun

chuanqisun commented Mar 12, 2025

Copy link
Copy Markdown
Author

I tried rebase, it has no effect because my change was actually based on 9eb71923ed02a2f23d81194feb9e99ef713f5f1b. If you want to do it the old school way, here is the patch file you can manually apply into your own branch.

2025-03-12-ts-interface-fix.patch

@jcubic

jcubic commented Mar 13, 2025

Copy link
Copy Markdown
Member

I will try cherry-picking your commits.

@jcubic

jcubic commented Mar 18, 2025

Copy link
Copy Markdown
Member

The failing tests are probably because of old version of the browsers that are not supported by SauceLabs anymore. They need to be updated to latest supported versions.

The change will need to wait for the tests to be fixed, since releases happen automatically after tests passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants