Conversation
Provides more obvious warning to users about side effects than just a comment. Signed-off-by: Nick Fox <nfox@redhat.com>
* Fix webhook flake Wait for resources to be deleted between test runs. Signed-off-by: Nick Fox <nfox@redhat.com> * Rework how operator tests are skipped Ginkgo Skip was pushing the DeferCleanup step in the Operator test container to run after the webhook test causing the BeforeAll resources created in the webhook tests to be deleted by the cleaner. Signed-off-by: Nick Fox <nfox@redhat.com> --------- Signed-off-by: Nick Fox <nfox@redhat.com> (cherry picked from commit c60358c) Signed-off-by: mkralik3 <mkralik@redhat.com>
Adapt TLSAdherence test to support OCP 5.0+ Signed-off-by: mkralik3 <mkralik@redhat.com> (cherry picked from commit abf4ee2) Signed-off-by: mkralik3 <mkralik@redhat.com>
Currently, during e2e test failure, logs gathering happens in "AfterAll" section. But since within the tests, many nested "When" blocks have "BeforeEach" section, when the test fails, ginkgo goes to the next "When" section and executes the "BeforeEach" section there, which leas to a cleanup of different resource, depends on the cleanup steps within specifc section. That leads to a state, when many gathered logs are empty, since the requested resource already deleted. That state, makes debugging harded. Move the logs gathering step to the "JustAfterEach" section. It will capture debug info immediately on test failure (before any cleanup or next BeforeEach runs). Signed-off-by: Maxim Babushkin <mbabushk@redhat.com>
Collaborator
|
@mkralik3: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
nrfox
approved these changes
Sep 16, 2026
Comment on lines
+222
to
+231
| // Calling Skip() from a BeforeAll makes Ginkgo defer the enclosing Ordered container's | ||
| // teardown (the cleaner) into the next top-level container, or drop it entirely. The | ||
| // cleaner then deletes resources belonging to whichever suite is running by then. So the | ||
| // checks below record why the specs cannot run and return, and each It skips itself. | ||
| var skipReason string | ||
| skipIfUnsupported := func() { | ||
| if skipReason != "" { | ||
| Skip(skipReason) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I'm not sure the webhook flake commit is necessary since the webhook tests were only added to 1.31 but it won't hurt to keep the tls adherence test consistent between branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2315 and related commits