Open
Conversation
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
istio-testing
added
the
size/L
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible for istiod to send multiple services which have address overlap. The clearest way I can envision this happening is two SE of resolution NONE in different namespaces. Right now ztunnel handles this scenario poorly, by overwriting
by_vipwith the most recently updatedService. This updatesby_vipto be ahashmapkeyed on VIP which contains avecofServiceinstead of a singleService. When performing VIP lookups in outbound (to determine which Service a client is trying to reach) we will prefer theServicein the same namespace, otherwise the canonical is used matching DNS lookup semantics more closely for this "reverse lookup" behavior.