-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/issue 309 changing photo logic from base64 to url approach #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
34ef3c2
Refactor blob storage logic for URL generation; delegate image mappin…
taraskibysh 5c72786
Updated seeder and some tests
MarkBevz50 ce61df7
Improved integration tests
MarkBevz50 cade56c
fix image DI according to url format and fix some tests
taraskibysh 36eebcc
implement code rabbit suggestion
taraskibysh 13674a2
add pagination result, refactor get team membesr logic accordingly
NovickVitaliy beefb15
fix integration test
NovickVitaliy 2a0e27c
small bug fix
NovickVitaliy c808746
suppress message about hmacmd5 in way4pay handler
NovickVitaliy 1428226
merge feature/issue-332
taraskibysh 9d9203d
separated exceptions into separate files and added validation on file…
taraskibysh 2238834
merge change from release
taraskibysh 1ae6abb
fix some integration tests
taraskibysh 7e40873
fix constants and add some tests
taraskibysh 6e538f1
minor fix
taraskibysh 11b9492
fix 1 test
taraskibysh da6c467
implement some suggestion
taraskibysh 8c3d48f
git try catch for directory creation
taraskibysh 3b81e08
add documentation for blobService and fix some error handling bugs
taraskibysh 4926ba6
Changed the description of exceptions and made some methods static
taraskibysh 875ec23
fix merge conflicts
taraskibysh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -158,4 +158,4 @@ dist | |
| *idea/ | ||
| *bin/ | ||
| *obj/ | ||
| *StaticFile/ | ||
| *wwwroot/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,15 +11,12 @@ public static class ImageConstants | |
| public static readonly string FailToUpdateImage = "Failed to update image"; | ||
| public static readonly string InvalidBase64String = "Invalid Base64 string."; | ||
| public static readonly string FailedToConvertBase64 = "Failed to convert Base64"; | ||
| public static readonly string InvalidIVLength = "Invalid IV length"; | ||
| public static readonly string ImageNotFoundGeneric = "Image not found"; | ||
| public static readonly string ImageBlobNameIsNull = "Image blob name is null"; | ||
| public static readonly string EncryptionFailed = "Encryption failed."; | ||
| public static readonly string DecryptionFailed = "Decryption failed."; | ||
| public static readonly string FailedToWriteEncryptedFile = "Failed to write encrypted file."; | ||
| public static readonly string FailedToReadOrDecryptFile = "Failed to read or decrypt file."; | ||
| public static readonly string UnexpectedBlobReadError = "Unexpected error during file retrieval."; | ||
| public static readonly string ImageDataNotAvailable = "Image data not available"; | ||
| public static readonly string FailedToSaveImage = "Failed to save the image."; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Extract this to a common constant. You can take a look at our pr: ita-social-projects/VictoryCenter-Client#52 |
||
| public static readonly string FailedToReadImage = "Failed to retrieve the image."; | ||
| public static readonly string HttpContextIsNotAvailable = "HttpContext is not available."; | ||
|
|
||
| public static string FieldIsRequired(string name) | ||
| { | ||
|
|
@@ -35,4 +32,9 @@ public static string FileNotFound(string filePath) | |
| { | ||
| return $"File not found: {filePath}"; | ||
| } | ||
|
|
||
| public static string WrongFileName(string name) | ||
| { | ||
| return $"An error occurred while retrieving the file {name}."; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid leaking database exception details to clients
Returning DbUpdateException.Message can expose internal DB details. Prefer a generic, user-safe message and log the exception server-side.
Apply:
Follow-up: If there’s a centralized logger in the handler pipeline, rely on it; otherwise consider logging ex with context here.
📝 Committable suggestion
🤖 Prompt for AI Agents