Add log file search by name - #540
Conversation
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
WalkthroughThe PR adds an administrator-only log-file name search endpoint. It performs case-insensitive partial matching, pagination, sorting, input validation, and filesystem error handling. Missing request parameters now return structured HTTP 400 validation responses. ChangesLog file name search
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This PR adds log-file name search with pagination, sorting, and request validation; no actionable merge-blocking risk remains beyond normal checks and review. Sequence Diagram(s)sequenceDiagram
participant AdminClient
participant LogFileController
participant LogFileServiceImpl
participant FileSystemLogFileDao
AdminClient->>LogFileController: GET /search with name and pageable
LogFileController->>LogFileServiceImpl: searchByName(name, pageable)
LogFileServiceImpl->>FileSystemLogFileDao: findByNameContainingIgnoreCase(trimmedName)
FileSystemLogFileDao-->>LogFileServiceImpl: matching metadata
LogFileServiceImpl-->>LogFileController: paginated responses
LogFileController-->>AdminClient: HTTP 200 page response
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…g-files-by-name # Conflicts: # src/main/java/com/itasocialacademy/oitassist/core/web/GlobalExceptionHandler.java
|



Summary by CodeRabbit
New Features
Bug Fixes
Tests