Skip to content

Add log file search by name - #540

Merged
ChernyavckiiPavlo merged 2 commits into
devfrom
features/363-search-log-files-by-name
Aug 18, 2026
Merged

Add log file search by name#540
ChernyavckiiPavlo merged 2 commits into
devfrom
features/363-search-log-files-by-name

Conversation

@ChernyavckiiPavlo

@ChernyavckiiPavlo ChernyavckiiPavlo commented Aug 14, 2026

Copy link
Copy Markdown
Contributor
  • Added case-insensitive log file search by partial file name
  • Added pagination and sorting support for search results
  • Added validation for blank search values and unsupported sort properties
  • Added handling for missing required request parameters
  • Refactored shared pagination and sorting logic in LogFileService
  • Added controller, service, and DAO tests for the new search functionality
  • Added coverage for log directory validation scenarios

Summary by CodeRabbit

  • New Features

    • Added an administrator-only log file search with case-insensitive, partial filename matching.
    • Search results support pagination and sorting.
    • Empty or unmatched searches return clear, paginated results.
  • Bug Fixes

    • Requests missing required parameters now return a clear HTTP 400 validation response, including the missing parameter name.
    • Improved handling of inaccessible, missing, or unreadable log files during searches.
  • Tests

    • Added coverage for search behavior, validation, pagination, sorting, and filesystem error scenarios.

@ChernyavckiiPavlo ChernyavckiiPavlo self-assigned this Aug 14, 2026
@ChernyavckiiPavlo ChernyavckiiPavlo linked an issue Aug 14, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d92ce7a-bc05-4a91-a5d2-c04ffc60e6e4

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d7ae5b76-ca3f-46dd-b3a2-fe86397012cc

📥 Commits

Reviewing files that changed from the base of the PR and between a225fe7 and 5739a20.

📒 Files selected for processing (9)
  • src/main/java/com/itasocialacademy/oitassist/core/web/GlobalExceptionHandler.java
  • src/main/java/com/itasocialacademy/oitassist/logfile/controller/LogFileController.java
  • src/main/java/com/itasocialacademy/oitassist/logfile/dao/FileSystemLogFileDao.java
  • src/main/java/com/itasocialacademy/oitassist/logfile/dao/LogFileDao.java
  • src/main/java/com/itasocialacademy/oitassist/logfile/service/LogFileService.java
  • src/main/java/com/itasocialacademy/oitassist/logfile/service/LogFileServiceImpl.java
  • src/test/java/com/itasocialacademy/oitassist/logfile/controller/LogFileControllerTest.java
  • src/test/java/com/itasocialacademy/oitassist/logfile/dao/FileSystemLogFileDaoTest.java
  • src/test/java/com/itasocialacademy/oitassist/logfile/service/LogFileServiceImplTest.java

Walkthrough

The PR adds an administrator-only log-file name search endpoint. It performs case-insensitive partial matching, pagination, sorting, input validation, and filesystem error handling. Missing request parameters now return structured HTTP 400 validation responses.

Changes

Log file name search

Layer / File(s) Summary
Filesystem search contract and scan
src/main/java/com/itasocialacademy/oitassist/logfile/dao/*, src/test/java/com/itasocialacademy/oitassist/logfile/dao/*
The DAO supports case-insensitive partial filename matching. The filesystem scan filters paths before reading metadata and tests cover matching, directories, disappearing files, and I/O failures.
Paginated search endpoint and validation
src/main/java/com/itasocialacademy/oitassist/logfile/service/*, src/main/java/com/itasocialacademy/oitassist/logfile/controller/LogFileController.java, src/main/java/com/itasocialacademy/oitassist/core/web/GlobalExceptionHandler.java, src/test/java/com/itasocialacademy/oitassist/logfile/service/*, src/test/java/com/itasocialacademy/oitassist/logfile/controller/*
The service validates and trims names, applies sorting and pagination, and builds responses for both retrieval paths. The administrator endpoint forwards search parameters. Missing parameters return HTTP 400 validation details. Tests cover request forwarding, pagination, sorting, empty results, and validation.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: ⚪ Minimal · up to 5739a

This PR adds log-file name search with pagination, sorting, and request validation; no actionable merge-blocking risk remains beyond normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant AdminClient
  participant LogFileController
  participant LogFileServiceImpl
  participant FileSystemLogFileDao
  AdminClient->>LogFileController: GET /search with name and pageable
  LogFileController->>LogFileServiceImpl: searchByName(name, pageable)
  LogFileServiceImpl->>FileSystemLogFileDao: findByNameContainingIgnoreCase(trimmedName)
  FileSystemLogFileDao-->>LogFileServiceImpl: matching metadata
  LogFileServiceImpl-->>LogFileController: paginated responses
  LogFileController-->>AdminClient: HTTP 200 page response
Loading

Poem

Names trimmed and files aligned,
Case-insensitive paths are found.
Pages sort and results flow,
Missing terms now clearly show.
Logs and tests keep watchful guard.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description summarizes the changes but omits the required Issue Link section and the ## Changed heading from the template. Add the required Issue Link section with the issue reference and include the ## Changed heading before the change summary.
Docstring Coverage ⚠️ Warning Docstring coverage is 5.41% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the primary change: adding log file search by name.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch features/363-search-log-files-by-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…g-files-by-name

# Conflicts:
#	src/main/java/com/itasocialacademy/oitassist/core/web/GlobalExceptionHandler.java
@sonarqubecloud

Copy link
Copy Markdown

@ChernyavckiiPavlo
ChernyavckiiPavlo merged commit 44d848d into dev Aug 18, 2026
7 checks passed
@ChernyavckiiPavlo
ChernyavckiiPavlo deleted the features/363-search-log-files-by-name branch August 18, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search Log Files by Name

2 participants