[Feature] add findToursByIds method to CompetitionFacade

[antonpampukha]

OitAssist PR

Issue Link 📋

#562

Summary by CodeRabbit

• New Features
  • Added support for retrieving tour details by a list of tour IDs.
  • Unmatched IDs are omitted, and empty input returns no results.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: da7cced5-acf8-4eae-b55b-ace685bc7492

📥 Commits

Reviewing files that changed from the base of the PR and between e6f6502 and f0fa481.

📒 Files selected for processing (2)

• src/main/java/com/itasocialacademy/oitassist/competition/api/CompetitionFacade.java
• src/main/java/com/itasocialacademy/oitassist/competition/service/CompetitionFacadeImpl.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Walkthrough

The competition facade now provides findToursByIds. The method rejects null input, returns an empty list for empty input, and maps matching tours to TourDetail results while omitting unmatched IDs.

Changes

Tour lookup

Layer / File(s)	Summary
Batch tour lookup contract and implementation src/main/java/com/itasocialacademy/oitassist/competition/api/CompetitionFacade.java, src/main/java/com/itasocialacademy/oitassist/competition/service/CompetitionFacadeImpl.java	The facade exposes findToursByIds(List<Long> tourIds). The implementation validates the input, handles empty lists, retrieves matching tours, and maps them to TourDetail objects.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f0fa4

This PR adds a localized facade method for retrieving tours by ID, with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: solenuk

Poem

Many tour IDs arrive in a row
Matching details now neatly flow
Null inputs meet a guarded gate
Empty lists return without wait
Missing tours quietly depart
A tidy lookup plays its part

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description includes the issue link but omits the required ## Changed section and does not summarize the implementation.	Add the ## Changed section and describe that the PR adds findToursByIds to CompetitionFacade, including its ID lookup and result behavior.
Docstring Coverage	⚠️ Warning	Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the primary change: adding findToursByIds to CompetitionFacade.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/add-retrieving-tours-to-competition-facade

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[antonpampukha]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.