[Feature] implement search through given userIds

[serggalel]

OitAssist PR

Issue Link 📋

#561

Summary by CodeRabbit

• New Features
  • Added user search support across email, first name, and surname.
  • Searches can be limited to a specified set of users and return matching user IDs.
  • Blank or missing search terms are handled without running a search.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 557e58cc-5455-49ea-8751-2e41812ef958

📥 Commits

Reviewing files that changed from the base of the PR and between b79c30a and 8c5ed27.

📒 Files selected for processing (5)

• src/main/java/com/itasocialacademy/oitassist/user/api/facade/UserFacadeImpl.java
• src/main/java/com/itasocialacademy/oitassist/user/api/interfaces/UserFacade.java
• src/main/java/com/itasocialacademy/oitassist/user/dao/repository/UserRepository.java
• src/main/java/com/itasocialacademy/oitassist/user/service/UserServiceImpl.java
• src/main/java/com/itasocialacademy/oitassist/user/service/interfaces/UserService.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Walkthrough

Adds constrained user-ID search through the facade, service, and repository layers. Search input is normalized, blank input returns Optional.empty(), and non-blank searches query candidate IDs by email, first name, surname, and name combinations.

Changes

Constrained user search

Layer / File(s)	Summary
Search contracts src/main/java/com/itasocialacademy/oitassist/user/api/interfaces/UserFacade.java, src/main/java/com/itasocialacademy/oitassist/user/service/interfaces/UserService.java	Adds facade and service methods for searching candidate user IDs.
Search normalization and query src/main/java/com/itasocialacademy/oitassist/user/service/UserServiceImpl.java, src/main/java/com/itasocialacademy/oitassist/user/dao/repository/UserRepository.java	Normalizes search input, skips blank searches, and queries candidate IDs by email, first name, surname, and combined name forms.
Facade integration src/main/java/com/itasocialacademy/oitassist/user/api/facade/UserFacadeImpl.java	Delegates constrained user-ID searches to UserService.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 8c5ed

This localized search API change has no actionable merge-blocking risk in the supplied evidence and is merge-ready after normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant UserFacadeImpl
  participant UserServiceImpl
  participant UserRepository
  UserFacadeImpl->>UserServiceImpl: findUserIdsBySearch(search, candidateIds)
  UserServiceImpl->>UserServiceImpl: normalizeSearch(search)
  UserServiceImpl->>UserRepository: findIdsBySearch(search, candidateIds)
  UserRepository-->>UserServiceImpl: matching user IDs
  UserServiceImpl-->>UserFacadeImpl: Optional<List<Long>>

Loading

Suggested reviewers: stinvestigator

Poem

Candidate IDs gather in line
Search terms normalize and shine
Blank input quietly departs
Names and emails map their parts
The facade sends results back fine

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description includes the required PR heading and issue link, but it does not include the required "Changed" section or a summary of the implementation.	Add the "## Changed" section and describe the new search behavior, including the affected facade, service, and repository methods and the handling of blank or null searches.
Docstring Coverage	⚠️ Warning	Docstring coverage is 46.15% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 5 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: implementing search within specified user IDs.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/implement-search-through-given-userIds

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[serggalel]

@CodeRabbit review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.