fix: federation jwks for signing EC#539
Open
peppelinux wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the handling of JWKS (JSON Web Key Sets) for signing and verifying JWTs in the OpenID4VCI metadata endpoint. The main change is to use federation JWKS exclusively for both signing and verification, instead of using a separate metadata JWKS. The tests have also been updated to reflect this logic and to ensure correct signature verification.
Key changes:
Metadata endpoint logic changes:
metadata_jwksfield has been removed from theMetadataHandlerclass. Now, onlyfederation_jwksis used for signing entity statements. (pyeudiw/satosa/frontends/openid4vci/endpoints/metadata_endpoint.py)entity_configurationmethod, the signing key andkidare now taken fromfederation_jwks, and theJWSHelperis initialized with a single JWK (not a list). (pyeudiw/satosa/frontends/openid4vci/endpoints/metadata_endpoint.py)Test updates:
MOCK_FEDERATION_JWKS_CONFIGand updated the test configuration to use it for federation keys, separating it fromMOCK_METADATA_JWKS_CONFIG. (pyeudiw/tests/satosa/frontends/openid4vci/mock_openid4vci.py)pyeudiw/tests/satosa/frontends/openid4vci/endpoints/test_metadata_endpoint.py)JWK,JWSHelper, andJWSVerificationErrorin the test file. (pyeudiw/tests/satosa/frontends/openid4vci/endpoints/test_metadata_endpoint.py)MOCK_FEDERATION_JWKS_CONFIGwhere appropriate. (pyeudiw/tests/satosa/frontends/openid4vci/endpoints/test_metadata_endpoint.py)