fix: disallow rtl behaviour - #222
Conversation
|
Hello @YogiHa , I tried running this code and the player is still showing reverted in changed language other than english, any suggestions? |
|
Did you restart the application after change the rtl status? |
mahamaad
left a comment
There was a problem hiding this comment.
Hey @YogiHa thank you for solution but this pr have some issue
1-please delete ',' in the end of line 1251
2-this change good in android but has an issue in iOS you need add Platform.OS === 'android' to your conditions like this:
in line 1251 I18nManager.isRTL ? 'row-reverse' : 'row' change to I18nManager.isRTL && Platform.OS === 'android' ? 'row-reverse' : 'row'
also change it in line 1424
...(I18nManager.isRTL ? { transform: [{ rotateY: '180deg' }] } : {}) change to ...(I18nManager.isRTL && Platform.OS === 'android' ? { transform: [{ rotateY: '180deg' }] } : {})
|
@mahamaad |
|
@YogiHa sorry u right my view had direction:'ltr' i delete it and work fine, only issue in line 1251 just delete ',' and work good, thank you. |
Hey, and thanks for this great package :)
Added a fix for opposite looking and behavior for
RTLusers.Currently it mandatory (as a Hebrew native speaker, never saw an opposite video player), in case it should be optional it can be added by adding a
disallowRtlprop and calculating accords.(The downside of prop controlled method that it will be achieved by either declaring
stylesas a function or by taking this optional styles outsideStyleSheet.create, therefore I did it currently mandatory)Tell me if anything else needed,
Yogi