Skip to content

Making ContentExtractor stateless#378

Merged
j0k3r merged 1 commit intomasterfrom
feat/stateless-content-extractor
Oct 7, 2025
Merged

Making ContentExtractor stateless#378
j0k3r merged 1 commit intomasterfrom
feat/stateless-content-extractor

Conversation

@j0k3r
Copy link
Copy Markdown
Owner

@j0k3r j0k3r commented Sep 26, 2025

Started with Claude to have a first draft and then update the whole stuff.

I'm just wondering if ExtractedContent should have getters or all keys public instead.

See #275 (comment)

@j0k3r j0k3r requested review from Kdecherf and jtojnar September 26, 2025 13:42
@j0k3r j0k3r added this to the 3.0.0 milestone Sep 26, 2025
@j0k3r

This comment has been minimized.

@jtojnar
Copy link
Copy Markdown
Collaborator

jtojnar commented Sep 26, 2025

all keys public instead.

With PHP 8.1 readonly properties, public properties sound cleanest to me.

@j0k3r j0k3r force-pushed the feat/stateless-content-extractor branch from e088c51 to 28a18d4 Compare September 30, 2025 14:10
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 97.02381% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.80%. Comparing base (e64248f) to head (28a18d4).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/Extractor/ContentExtractor.php 96.75% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #378      +/-   ##
============================================
+ Coverage     95.65%   95.80%   +0.14%     
+ Complexity      695      691       -4     
============================================
  Files            16       17       +1     
  Lines          1866     1931      +65     
============================================
+ Hits           1785     1850      +65     
  Misses           81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j0k3r j0k3r merged commit f2d2e0b into master Oct 7, 2025
10 checks passed
@j0k3r j0k3r deleted the feat/stateless-content-extractor branch October 7, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants