Update regex for empty nodes for also excluding img#381
Open
HolgerAusB wants to merge 1 commit intoj0k3r:masterfrom
Open
Update regex for empty nodes for also excluding img#381HolgerAusB wants to merge 1 commit intoj0k3r:masterfrom
HolgerAusB wants to merge 1 commit intoj0k3r:masterfrom
Conversation
Some websites using closing `</img>` nodes which is not defined in HTML. In most cases, this results in `<img src="..."></img>` which is currently detected as empty node and therefore removed by graby. So all images from those domains can currently not be fetched by wallabag. This will fix lot of issues in wallabagger for missing images.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
============================================
- Coverage 95.80% 95.71% -0.10%
Complexity 691 691
============================================
Files 17 17
Lines 1931 1890 -41
============================================
- Hits 1850 1809 -41
Misses 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some websites using closing
</img>nodes which is not defined in HTML. In most cases, this results in<img src="..."></img>which is currently detected as empty node and therefore removed by graby. So all images from those domains can currently not be fetched by wallabag.This will fix lot of issues in wallabagger for missing images.
example: https://taz.de/Stadtbilddebatte-wird-praktisch/!6136666/