Remove sqlite cache storage - #416
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the optional sqlite-backed LeetCode question cache and standardizes on the JSON cache implementation, simplifying the cache system and trimming related dependencies.
Changes:
- Deleted the sqlite cache implementation (
leetcode/cache_sqlite.go) and removed the build-tag split between sqlite vs JSON caches. - Kept JSON as the single cache backend by removing the
!sqlitebuild tag fromleetcode/cache_json.go. - Removed sqlite-related module dependencies from
go.mod/go.sum(plus related transitive deps).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
leetcode/question.go |
Removes sqlite-specific comment from JSON unmarshalling path. |
leetcode/cache_sqlite.go |
Deletes the sqlite cache implementation entirely. |
leetcode/cache_json.go |
Makes JSON cache unconditional (no build tag gating). |
go.mod |
Drops direct/indirect dependencies related to sqlite cache support. |
go.sum |
Removes checksums for dropped sqlite-related dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the optional sqlite-backed question cache and keep JSON as the single cache implementation.
Also drops the sqlite cache dependency chain.