fix: allow dash-prefixed positional args without misinterpreting as options#1161
Open
kagura-agent wants to merge 1 commit intojackwener:mainfrom
Open
fix: allow dash-prefixed positional args without misinterpreting as options#1161kagura-agent wants to merge 1 commit intojackwener:mainfrom
kagura-agent wants to merge 1 commit intojackwener:mainfrom
Conversation
…ptions (jackwener#1160) When a positional argument value starts with a dash (e.g. `opencli boss detail -123456abdc`), Commander.js misinterprets it as an unknown option flag and errors out. Fix: override parseOptions on commands with positional args to insert a `--` sentinel before the first unrecognized dash-prefixed token, so Commander treats it as an operand. Fixes jackwener#1160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a positional argument value starts with a dash (e.g.
opencli boss detail -123456abdc), Commander.js misinterprets it as an unknown option flag and throwserror: unknown option '-123456abdc'.This affects any command where positional argument values can legitimately start with
-(like BOSS直聘 security IDs).Fixes #1160
Solution
Override
parseOptionson commands that have positional arguments. Before Commander's option parsing runs, we scan for unrecognized dash-prefixed tokens and insert a--sentinel so Commander treats them as operands rather than options.This is a framework-level fix — all 351 commands with positional args benefit automatically.
Changes
src/commanderAdapter.ts: AddparseOptionsoverride for commands with positional argssrc/commanderAdapter.test.ts: Add 3 test cases (dash-prefixed ID, dash ID with options, normal ID)Testing
article-extract.test.tsunrelated to this change)npx tsc --noEmitclean