Open
Conversation
Owner
|
Sorry for taking so long to respond. I checked out your branch and when I went to run it on Ruby 2.4.1 it failed badly. Not your fault - not a problem with your code, but rather, older versions of some of this project's dependencies don't run well on 2.4.1 due to some new Fixnum compatibility issues. Rest assured I'm going to merge this in, and possibly bump some versions of dependencies. Thanks again for your contribution, I appreciate the work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For performance reasons, this adds a preference for the
bin/rubocopthat might be installed on some projects to the defaultbundle execbehavior