Add support of bytes type of AMQP field#139
Open
F0Rt04ka wants to merge 1 commit into
Open
Conversation
WyriHaximus
requested changes
Aug 1, 2023
WyriHaximus
left a comment
WyriHaximus
left a comment
Collaborator
There was a problem hiding this comment.
Would prefer, if there are unit tests for the long string to also included tests for the bytes type to be honest. Assuming this is testable.
Collaborator
|
@F0Rt04ka Do you want to add tests to this or should I take over and add them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support of bytes type of AMQP field.
I got error "Unhandled field type 0x78 ('x')" and found fix in php-amqplib
https://github.com/php-amqplib/php-amqplib/blob/6bf2e5c49759fc386a4988f3af1761cbfb63d367/PhpAmqpLib/Wire/AMQPReader.php#L402