Soft line breaks before emphasis - #13
Open
waterson wants to merge 1 commit into
Open
Conversation
waterson
marked this pull request as ready for review
August 14, 2026 20:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked stores a soft line break at the end of the preceding text token when the next line begins with inline formatting. Marklassian removed that terminal newline instead of normalizing it to a space, causing adjacent text to run together.
This PR preserves soft line breaks between inline nodes while retaining the existing behavior around standalone images and explicit hard breaks.
Closes #12.
Testing
npm run check,npm run build --workspace=lib, andnpm test --workspace=libpass; the regression test covers the reported strong-emphasis boundary.