keyv - feat: moving storage setMany to use KeyvEntry

[jaredwray]

Please check if the PR fulfills these requirements

• Followed the Contributing and Code of Conduct guidelines.
• Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
keyv - feat: moving storage setMany to use KeyvEntry

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the setMany method's type signature across the Keyv core and its various storage adapters. By introducing a generic KeyvEntry type and consistently applying it, the change significantly enhances type safety and code consistency when handling multiple key-value entries, making the API more robust and predictable for developers.

Highlights

• Standardized setMany Input Type: The setMany method in the Keyv core and its storage adapters now consistently uses the KeyvEntry type for its input array, ensuring uniformity across implementations.
• Introduced Generic KeyvEntry Type: The KeyvEntry type definition was updated to be generic, allowing for better type inference and safety for the value property within key-value entries.
• Improved Type Safety Across Adapters: All affected storage adapters (Dynamo, Etcd, Memcache, Mongo, Valkey) have been updated to reflect these type changes, enhancing overall type safety and consistency when handling multiple entries.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the KeyvEntry type to be generic and updates the setMany method signatures across various storage adapters (Dynamo, Etcd, Memcache, Mongo, Valkey) to use this new generic type. A review comment points out a type safety regression in the etcd adapter's setMany method, suggesting that KeyvEntry[] should be KeyvEntry<Value>[] to maintain type consistency. Additionally, the ttl property, now part of KeyvEntry, is currently ignored in the etcd adapter's setMany implementation.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: acc2307f8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.88%. Comparing base (66dcdbd) to head (c5e1863).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1903   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          37       37           
  Lines        3416     3420    +4     
  Branches      557      560    +3     
=======================================
+ Hits         3412     3416    +4     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jaredwray]

@gemini /review

[gemini-code-assist]

Code Review

This pull request significantly improves the type safety and consistency of the setMany method across various Keyv storage adapters. Key changes include making the KeyvEntry type generic, updating method signatures to use KeyvEntry<Value>, and refining JSDoc comments. A new test:sequential script was also added to package.json, and property access in storage/dynamo/test/test.ts was modernized. The review comments identified several type-related issues, specifically in the storage/etcd adapter where the set method's signature is overly restrictive, leading to unsafe casts in setMany and the iterator's value retrieval. In the storage/redis adapter, unsafe value as string type assertions were noted, which could cause runtime errors if non-string values are used, with a recommendation to use String(value) for safer conversion.

[jaredwray]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3fe243852d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".