Skip to content

keyv - feat: browser compatability#1907

Merged
jaredwray merged 2 commits intomainfrom
keyv---feat-browser-compatability
Mar 26, 2026
Merged

keyv - feat: browser compatability#1907
jaredwray merged 2 commits intomainfrom
keyv---feat-browser-compatability

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented Mar 26, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
keyv - feat: browser compatability

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces browser compatibility testing for the keyv core package by adding happy-dom and implementing new test suites for static analysis and runtime verification. The static analysis ensures no Node.js built-ins are imported, while the runtime tests validate core operations and serialization in a browser-like environment. Feedback includes suggestions to dynamically generate the list of bare Node.js modules for better maintainability, use Vitest's fake timers instead of sleep to avoid test flakiness, and refactor test setups using beforeEach to reduce code duplication.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b99aa3d8d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.88%. Comparing base (03d050b) to head (29cfdc9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1907      +/-   ##
==========================================
- Coverage   99.88%   99.88%   -0.01%     
==========================================
  Files          37       37              
  Lines        3440     3424      -16     
  Branches      567      565       -2     
==========================================
- Hits         3436     3420      -16     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit 36f734c into main Mar 26, 2026
12 checks passed
@jaredwray jaredwray deleted the keyv---feat-browser-compatability branch March 26, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant