Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces browser compatibility testing for the keyv core package by adding happy-dom and implementing new test suites for static analysis and runtime verification. The static analysis ensures no Node.js built-ins are imported, while the runtime tests validate core operations and serialization in a browser-like environment. Feedback includes suggestions to dynamically generate the list of bare Node.js modules for better maintainability, use Vitest's fake timers instead of sleep to avoid test flakiness, and refactor test setups using beforeEach to reduce code duplication.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b99aa3d8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1907 +/- ##
==========================================
- Coverage 99.88% 99.88% -0.01%
==========================================
Files 37 37
Lines 3440 3424 -16
Branches 567 565 -2
==========================================
- Hits 3436 3420 -16
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
keyv - feat: browser compatability