Skip to content

keyv - feat: clean up of code with fixes and helpers#1910

Merged
jaredwray merged 29 commits intomainfrom
keyv---feat-clean-up-of-code-with-fixes-and-helpers
Mar 27, 2026
Merged

keyv - feat: clean up of code with fixes and helpers#1910
jaredwray merged 29 commits intomainfrom
keyv---feat-clean-up-of-code-with-fixes-and-helpers

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented Mar 27, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
keyv - feat: clean up of code with fixes and helpers

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (12d728b) to head (63d766b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #1910      +/-   ##
===========================================
+ Coverage   99.88%   100.00%   +0.11%     
===========================================
  Files          37        38       +1     
  Lines        3409      3450      +41     
  Branches      526       531       +5     
===========================================
+ Hits         3405      3450      +45     
+ Misses          4         0       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the core Keyv implementation by moving the main Keyv class from index.ts to a dedicated keyv.ts file and updating internal imports. The review feedback identifies several opportunities to improve the robustness and performance of the refactored code. Key suggestions include handling Promise.allSettled results more safely by checking fulfillment status instead of using unsafe type assertions, replacing non-idiomatic for...in array iteration with for...of, and optimizing the hasMany method by executing checks in parallel using Promise.all instead of sequential awaits.

@jaredwray jaredwray merged commit ab15952 into main Mar 27, 2026
12 checks passed
@jaredwray jaredwray deleted the keyv---feat-clean-up-of-code-with-fixes-and-helpers branch March 27, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant