Skip to content

keyv - feat: (breaking) memory adapter, bridge adapter, keyv overhaul#1913

Merged
jaredwray merged 37 commits intomainfrom
keyv---feat-adding-KeyvMemoryAdapter-for-Map-like-stores
Mar 29, 2026
Merged

keyv - feat: (breaking) memory adapter, bridge adapter, keyv overhaul#1913
jaredwray merged 37 commits intomainfrom
keyv---feat-adding-KeyvMemoryAdapter-for-Map-like-stores

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented Mar 29, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
keyv - feat: (breaking) memory adapter, bridge adapter, keyv overhaul

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors Keyv v6 to implement a new 3-tier storage resolution system using KeyvMemoryAdapter and KeyvBridgeAdapter, centralizes decoding and expiration logic, and introduces encryption support. Feedback identifies a bug in setMany where non-storable values are incorrectly handled and a regression in has() that bypasses the decoding pipeline for expiration checks. Additionally, the reviewer noted redundant expiration logic within the adapters and suggested a memory optimization for the memory adapter's clear() method when handling large namespaced stores.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc03e3897b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (eaf7281) to head (3cee8e9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main     #1913    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           39        40     +1     
  Lines         3558      3679   +121     
  Branches       539       544     +5     
==========================================
+ Hits          3558      3679   +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit 5b57c68 into main Mar 29, 2026
12 checks passed
@jaredwray jaredwray deleted the keyv---feat-adding-KeyvMemoryAdapter-for-Map-like-stores branch March 29, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant