Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors Keyv v6 to implement a new 3-tier storage resolution system using KeyvMemoryAdapter and KeyvBridgeAdapter, centralizes decoding and expiration logic, and introduces encryption support. Feedback identifies a bug in setMany where non-storable values are incorrectly handled and a regression in has() that bypasses the decoding pipeline for expiration checks. Additionally, the reviewer noted redundant expiration logic within the adapters and suggested a memory optimization for the memory adapter's clear() method when handling large namespaced stores.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc03e3897b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1913 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 39 40 +1
Lines 3558 3679 +121
Branches 539 544 +5
==========================================
+ Hits 3558 3679 +121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
keyv - feat: (breaking) memory adapter, bridge adapter, keyv overhaul