Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1923 +/- ##
===========================================
- Coverage 100.00% 99.94% -0.06%
===========================================
Files 40 40
Lines 3728 3974 +246
Branches 554 636 +82
===========================================
+ Hits 3728 3972 +244
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new checkExpired configuration option to Keyv, enabling optional expiry validation at the Keyv layer. To support this and improve consistency, multiple storage adapters (Memory, DynamoDB, Etcd, Memcache, MongoDB, MySQL, Postgres, and SQLite) have been updated to perform manual expiry checks and cleanup during read operations. Feedback focuses on optimizing performance by avoiding .toArray(), and reducing database overhead in SQL adapters by avoiding DELETE queries on every cache miss.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
keyv - feat: (breaking) by default keyv no longer checks expires