Skip to content

encrypt-web - feat: adding new web crypto module#1928

Merged
jaredwray merged 5 commits intomainfrom
encrypt-web---feat-adding-new-web-crypto-module
Mar 31, 2026
Merged

encrypt-web - feat: adding new web crypto module#1928
jaredwray merged 5 commits intomainfrom
encrypt-web---feat-adding-new-web-crypto-module

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
encrypt-web - feat: adding new web crypto module

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the @keyv/encrypt-web package, which provides Web Crypto API encryption support for Keyv, and adds documentation for the @keyv/encrypt-node package. The implementation includes support for AES-GCM and AES-CBC algorithms with cross-compatibility between the node and web versions. Feedback focuses on improving the efficiency of the manual Base64 conversion and simplifying the buffer concatenation logic to enhance maintainability.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e0ce437) to head (a222b1c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1928   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        43    +1     
  Lines         4097      4164   +67     
  Branches       661       662    +1     
=========================================
+ Hits          4097      4164   +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit ad25c15 into main Mar 31, 2026
12 checks passed
@jaredwray jaredwray deleted the encrypt-web---feat-adding-new-web-crypto-module branch March 31, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant