Skip to content

test-suite - feat (breaking) overhaul based on v6 changes#1931

Merged
jaredwray merged 13 commits intomainfrom
test-suite---feat-(breaking)-overhaul-based-on-v6-changes
Apr 1, 2026
Merged

test-suite - feat (breaking) overhaul based on v6 changes#1931
jaredwray merged 13 commits intomainfrom
test-suite---feat-(breaking)-overhaul-based-on-v6-changes

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented Apr 1, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
test-suite - feat (breaking) overhaul based on v6 changes

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4bdd3db) to head (dfe1861).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main     #1931    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           43        52     +9     
  Lines         4177      4478   +301     
  Branches       667       668     +1     
==========================================
+ Hits          4177      4478   +301     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34139043e8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the @keyv/test-suite package to introduce a modular and type-safe architecture, including a new storageTestSuite for direct adapter testing and enhanced JSDoc documentation. Across the repository, tests have been updated to align with the new suite structure and a consistent vitest API. The review feedback focuses on improving the robustness of iterator tests by ensuring assertions verify the complete set of yielded items—including collection size and value accuracy—to prevent false positives from empty or incomplete iterations.

@jaredwray jaredwray merged commit 27e3695 into main Apr 1, 2026
12 checks passed
@jaredwray jaredwray deleted the test-suite---feat-(breaking)-overhaul-based-on-v6-changes branch April 1, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant