test-suite - feat (breaking) overhaul based on v6 changes#1931
test-suite - feat (breaking) overhaul based on v6 changes#1931
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1931 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 43 52 +9
Lines 4177 4478 +301
Branches 667 668 +1
==========================================
+ Hits 4177 4478 +301 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34139043e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Code Review
This pull request refactors the @keyv/test-suite package to introduce a modular and type-safe architecture, including a new storageTestSuite for direct adapter testing and enhanced JSDoc documentation. Across the repository, tests have been updated to align with the new suite structure and a consistent vitest API. The review feedback focuses on improving the robustness of iterator tests by ensuring assertions verify the complete set of yielded items—including collection size and value accuracy—to prevent false positives from empty or incomplete iterations.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
test-suite - feat (breaking) overhaul based on v6 changes