fix(jac-gpt): import byllm from jaclang.byllm after core fold#668
Merged
Conversation
byLLM was folded into jaclang core (jac/jaclang/byllm), so the top-level `byllm` package no longer exists. The jac-gpt server was still importing `byllm.lib` / `byllm.types`, which now fails at load with "No module named 'byllm'" and breaks the jaseci jacpack CI. Point the four import sites at the new `jaclang.byllm` module path: - services/jacServer.jac - services/jacServer.impl.jac - services/generate_doc_links.jac - services/testing/rag_testing.jac
jaseci migrated jaclang to a self-contained Zig binary: `jac/` no longer ships a pyproject.toml and the `jac-byllm` / `jac-scale` package dirs are gone (folded into the single `jac` binary). The old install method (`pip install -e /tmp/jaseci/jac` + `jac install -e .../jac-byllm`) therefore failed at setup, leaving this canary red on main for days. Rework the workflow to mirror jaseci's own CI: - Check out jaseci at the workspace root and reuse its `setup-jac` composite action to build + cache the binary; check out Agentic-AI into ./app. - Install the serve and byllm runtime capability closures with `jac install --global` (pins mirror capabilities.jac). - Install Playwright via `jac install playwright --global` and run E2E with `jac test` (the binary provides jaclang + pytest; system pytest has neither). - Bump the timeout to 60m to cover the cold binary build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
byLLM was folded into jaclang core (
jac/jaclang/byllm), so the top-levelbyllmpackage no longer exists onjasecimain. The jac-gpt server still importedbyllm.lib/byllm.types, sojac start main.jacfails at load withNo module named 'byllm', which breaks the jaseci jacpack integration CI (test-pypi-build-> "Start jac-gpt server").Fix
Repoint the four import sites at the new
jaclang.byllmmodule path (matches the canonical usage across jaseci examples/docs, e.g.import from jaclang.byllm.lib { Model }):services/jacServer.jac:byllm.lib->jaclang.byllm.libservices/jacServer.impl.jac:byllm.types->jaclang.byllm.typesservices/generate_doc_links.jac:byllm.lib->jaclang.byllm.libservices/testing/rag_testing.jac:byllm.lib->jaclang.byllm.libThe runtime
llmcapability (litellm, pillow, httpx, loguru) is already installed--globalby the CI, so only the import path needed updating.Once merged, the auto-generated jac-gpt jacpack regenerates from
mainand the jaseci CI passes.