Open
Conversation
Follow principle of least surprise: People expect --version to exist. Follow principle of least output: Nothing on stdout except if requested. (Dealing with the INFO output is for another PR.) Compare e.g. perl, python. * Have -V and --version (avoid -v, it is usually --verbose) * Do not print version string to stdout for --help, nor on startup * Log the version string at INFO level during non --help startup No testing for --version/-V, there is no logic to test (just a getter)
Author
|
The failure looks like an old JVM trying to load a newer-format class file. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not 100% sure if this meets project standards, just let me know what needs to be done and what can be improved.