allow managing FlexMark (markdown) plugin and options#788
Open
jderuette wants to merge 12 commits intojbake-org:masterfrom
Open
allow managing FlexMark (markdown) plugin and options#788jderuette wants to merge 12 commits intojbake-org:masterfrom
jderuette wants to merge 12 commits intojbake-org:masterfrom
Conversation
Need to add depenecy manually :( Added unitTest
more info https://github.com/vsch/flexmark-java/wiki/Admonition-Extension end user must add manually admonition.css (from AdmonitionExtension.getDefaultCSS()) and admonition.js (from AdmonitionExtension.getDefaultScript())
By Default use a "/img/xxxx" folder. User MUST add this folder to his WebSite
more info https://github.com/vsch/flexmark-java/wiki/Extensions#gfm-users use @xxx and not #xxx (type in documentation : see https://github.com/vsch/flexmark-java/blob/master/flexmark-ext-gfm-users/src/test/resources/gfm_users_ast_spec.md for more details)
also adding missing dependency fo gitLab Extension. commit simillar to previous but on correct branch (cherrypicking problems)
ottlinger
reviewed
Jun 8, 2025
| classOwner = attributeDetails[0]; | ||
| fieldName = attributeDetails[1]; | ||
| }else { | ||
| logger.info("MarkDown option '{}', dosen't have a owner ALL holder with that attribute will be changed and may cause strange beahviors", attributeDetails.toString()); |
Contributor
There was a problem hiding this comment.
Please reformat this file .... what is the info log supposed to tell the user?
"Markdown option '' does not have an ALL owner. You may experience strange behaviour as this attribute is applied in a different manner"?
Author
There was a problem hiding this comment.
File Format : DONE.
For the LOG : many classes hold attributs configuration ("owner"). Without qualifier ALL Owner (if they have the exact same name for attribute) will be modified with the new value. This may cause strange behavior. If a Plugin is added (and have an attribute with the same name) will affected too.
Log replaced with "MarkDown option '{}', dosen't have a owner. ALL holder with that attribute will be modified. You may experience strange behaviour"
ottlinger
reviewed
Jun 8, 2025
ottlinger
reviewed
Jun 8, 2025
ottlinger
reviewed
Jun 8, 2025
ottlinger
reviewed
Jun 8, 2025
ottlinger
reviewed
Jun 8, 2025
ottlinger
reviewed
Jun 8, 2025
ottlinger
reviewed
Jun 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for issue #759
Allow management of all Flexmark Plugins.
Allow management of most flexmark Options.