Fix asciidoctor.option.requires parsing for diagram support#801
Open
ascheman wants to merge 1 commit intojbake-org:masterfrom
Open
Fix asciidoctor.option.requires parsing for diagram support#801ascheman wants to merge 1 commit intojbake-org:masterfrom
ascheman wants to merge 1 commit intojbake-org:masterfrom
Conversation
DefaultJBakeConfiguration.getAsciidoctorOption() returns a List<String>,
but the old code used String.valueOf(list).split(",") which produced
values like "[asciidoctor-diagram]" with literal brackets, causing
JRuby require to fail silently.
parseRequires() now handles both Collection and comma-separated String
forms correctly. Adds unit tests and an integration test with
asciidoctor-diagram rendering a PlantUML sequence diagram.
Fixes jbake-org#778
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asciidoctor.option.requiresparsing:DefaultJBakeConfiguration.getAsciidoctorOption()returns aList<String>, but the old code usedString.valueOf(list).split(",")which produced values like[asciidoctor-diagram]with literal brackets, causing JRubyrequireto fail silentlyparseRequires()method that handles bothCollectionand comma-separatedStringforms correctlyparseRequires()and an integration test that renders a PlantUML sequence diagram viaasciidoctor-diagramasciidoctor.option.requiresindefault.propertiesFixes #778
Test plan
parseRequires()cover: single/multi-element lists, comma-separated strings, whitespace trimming, null/empty handling, bracket-leak regression guardasciidoctor.option.requires=asciidoctor-diagramand verifies a PlantUML sequence diagram is rendered to an<img>tag./gradlew :jbake-core:test)🤖 Generated with Claude Code