Make circular type forwarder protection thread-safe#978
Open
ItsZil wants to merge 1 commit intojbevain:masterfrom
Open
Make circular type forwarder protection thread-safe#978ItsZil wants to merge 1 commit intojbevain:masterfrom
ItsZil wants to merge 1 commit intojbevain:masterfrom
Conversation
ItsZil
force-pushed
the
circular-type-thread-safe
branch
from
0e13a43 to
ee91148
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #806 added protection against circular type forwarders using an instance-level
bool reentrancyGuardvariable. This created race conditions when multiple threads resolved the sameExportedType.This PR replaces the bool with a
[ThreadStatic] static int reentrancyDepthcounter, allowing forwarding up toconst int MaxForwardingDepth = 16depth, which is thread-safe and supports legitimate forwarding chains.I added a test (
TypeForwarderMultiLevel) that resolves a simple forwarding chain.