Created plugin for getting artifacts from local dir - #159
Conversation
Enable plugin with --artifact-local-enable Set the director with --artifact-local-dir (default is artifacts) Fixes: 114
|
|
||
| for f in sorted(self.artifact_files): | ||
| self.log.debug("Copying local artifact %s" % os.path.basename(f)) | ||
| shutil.copy2(f, self.output) |
There was a problem hiding this comment.
how this handle target?
https://github.com/jboss-dockerfiles/dogen/blob/develop/dogen/generator.py#L289
artifacts in dogen can be copied anywhere into the subtree of output directory - this functionality is crucial to CCT plugin. This probably needs to be updated. @goldmann opinion?
There was a problem hiding this comment.
The target name could be used in the artifacts directory. The sources would then find it and pick it up.
I'll need to update to handle subdirectories. If the artifacts directory contains the subdirectories and target names, they can be copied over.
rwngwn
left a comment
rwngwn
left a comment
There was a problem hiding this comment.
Also I'm thinking this plugin should not copy everything from local cached directory. It should probably copy only artifacts requested by sources section of image.yaml and place them to proper place specified by target attribute.
2 participants
Enable plugin with --artifact-local-enable
Set the director with --artifact-local-dir (default is artifacts)
Fixes: 114