Skip to content

Use WinitSettings::desktop_app in editor template to reduce CPU usage #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theotherphil wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use WinitSettings::desktop_app in editor template to reduce CPU usage #258

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a46af72
Use WinitSettings::desktok_app in editor template to reduce CPU usage
May 21, 2026
8f85aee
Merge branch 'main' into desktop_app
jbuehler23 May 21, 2026
eeafa31
Merge branch 'main' into desktop_app
jbuehler23 May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion templates/game-static/src/bin/editor.rs.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ use bevy::{
asset::AssetPlugin,
image::{ImageAddressMode, ImagePlugin, ImageSamplerDescriptor},
prelude::*,
winit::WinitSettings,
};
use jackdaw::prelude::*;
use jackdaw::project_select::PendingAutoOpen;
Expand Down Expand Up @@ -59,7 +60,8 @@ fn main() -> AppExit {
// bevy_enhanced_input.
.add_plugins((PhysicsPlugins::default(), EnhancedInputPlugin))
.add_plugins(EditorPlugins::default())
.add_plugins({{crate_name}}::MyGamePlugin);
.add_plugins({{crate_name}}::MyGamePlugin)
.insert_resource(WinitSettings::desktop_app());

@jbuehler23 jbuehler23 May 21, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will likely need to add this to all templates - dylibs, extensions, etc

@ThierryBerger ThierryBerger May 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't you want to add this to the editor itself ? rather than templates ?

(I'm ok with adding it to templates but I feel it would benefit more in the editor itself ?

oh that is the template for a standalone editor for a project 🤯 👍

Actually, if the editor embeds the main game, would it be a risk to have stutter when "play in editor" mode ? it would need to switch mode ?

@jbuehler23 jbuehler23 May 25, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i think this be baked into the editor itself i think


if let Some(root) = project_root.filter(|p| p.is_dir()) {
// `skip_build = true`: this binary IS the editor; no
Expand Down
Loading