Closed
Conversation
Owner
|
Thanks! Would you mind squashing the commits? |
Added JV-880 v1.00 hashes and made a few corrections Reverted change of version numbers for JV-880, since there appears to be confusion around the internet about how to write them.
akse0435
force-pushed
the
JV-880-v1.00-hashes
branch
from
307af79 to
3a24cac
Compare
Author
|
Should be done now. I've never tried squashing before, so I hope I did it correctly. |
Owner
|
LGTM, thanks. One thing I would suggest for next time is to discard any commit messages for changes that you reverted. Here I would use I've manually merged this one outside of github with an edited commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds hashes for JV-880 version 1.0.0. ROM2 in version 1.0.1 actually had the part number for version 1.0.0, R15209386, writen in the code even though the hash was the right one for version 1.0.1, so I changed the part number to the right one, R15209481, and used R15209386 with the right has in version 1.0.0. I also added version number for the SCC-1A set, it's v1.30.