fix(esm): provide separate CJS and ESM versions of load-module-native - #419
Merged
Conversation
The CJS build was emitting require("./load-module-native.mjs") which
fails in environments like Jest+esbuild that can't require() an .mjs
file with export syntax. Now the CJS build references a .js file using
module.exports while the ESM bundle references the .mjs file, resolved
via a rollup resolveId plugin.
Fixes #418
jeffijoe
force-pushed
the
fix/esm-again-fr
branch
from
March 3, 2026 14:56
78c7883 to
ee38f4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CJS build was emitting require("./load-module-native.mjs") which fails in environments like Jest+esbuild that can't require() an .mjs file with export syntax. Now the CJS build references a .js file using module.exports while the ESM bundle references the .mjs file, resolved via a rollup resolveId plugin.
Fixes #418