Skip to content

Cleanup Deletion Logic#1940

Merged
LePips merged 6 commits into
jellyfin:mainfrom
JPKribs:deleteCleanup
Mar 17, 2026
Merged

Cleanup Deletion Logic#1940
LePips merged 6 commits into
jellyfin:mainfrom
JPKribs:deleteCleanup

Conversation

@JPKribs

@JPKribs JPKribs commented Mar 13, 2026

Copy link
Copy Markdown
Member

Summary

Moves the deletion logic to a confirmation message instead of a whole view. Currently works for iOS. StateAdapter I'm fighting a bit but should hopefully have that soon.

Video

iOS

Simulator.Screen.Recording.-.iPhone.-.2026-03-13.at.14.04.23.mov

tvOS

WIP

@JPKribs JPKribs added developer Alters the developer experience iOS Impacts iOS or iPadOS tvOS Impacts tvOS labels Mar 13, 2026
@JPKribs

JPKribs commented Mar 13, 2026

Copy link
Copy Markdown
Member Author

Okay. I figured out tvOS but the state adapter needs to exist on the ActionHStack or on the ItemView since the ItemEditorMenu isn't persisting when a button is selected. Let me know if that is wrong but 2 routes I am thinking:

  1. Make those changes now only to rework them in Posters, Libraries, Home #1752 since those are both reworked there.
  2. Just comment out deletion logic for tvOS and address it either as part of Posters, Libraries, Home #1752 or after it.

I'm in favor of 2 but game for whatever.

@JPKribs JPKribs marked this pull request as ready for review March 15, 2026 02:07

@LePips LePips left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just implement deleting on tvOS in #1752.

@LePips LePips merged commit b3f9b3a into jellyfin:main Mar 17, 2026
4 checks passed
@JPKribs JPKribs deleted the deleteCleanup branch March 17, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer Alters the developer experience iOS Impacts iOS or iPadOS tvOS Impacts tvOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants