Feature/ios chromecast phase1 spine#1973
Open
AymanL wants to merge 14 commits into
Open
Conversation
JPKribs
requested changes
Apr 13, 2026
| MARKETING_VERSION = 1.0; | ||
| OTHER_CFLAGS = ""; | ||
| PRODUCT_BUNDLE_IDENTIFIER = org.jellyfin.swiftfin; | ||
| PRODUCT_BUNDLE_IDENTIFIER = org.ayman.swiftfin; |
Member
There was a problem hiding this comment.
Please don't include custom bundle identifier changes.
LePips
requested changes
Apr 13, 2026
LePips
left a comment
Member
There was a problem hiding this comment.
Thank you for the consideration of breaking these up into PRs, but this is probably something I would request at least a big chunk of it at once for architectural input. I've taken a look at your own PRs for the implementation and we would have to go in a very different direction.
For some guidance:
- This should be implemented as a
MediaPlayerProxy, like aChromeCastMediaPlayerProxy. This wouldn't require any specific cast considerations inMediaPlayerManagerand elsewhere throughout the app. - The video player should have work to have it be given a proxy and be able to have the proxy be able to be changed
Initially, let's have this as an experimental feature. I haven't even gotten into video player overlay changes or the ability to launch straight into a cast from elsewhere throughout the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the Google Cast iOS Sender SDK into the project as Phase 1 (out of 5, already-made, branches) of the Chromecast feature. No Cast UI is exposed in this PR, nothing visible to users. The goal is to prove the dependency integrates cleanly, the SDK initializes correctly at launch, and the receiver identity contract is tested and pinned.
All phases code has been tested and is building and running on my iPhone, starting from phase 3 they are all able to cast videos. If something is not working on your machine, I'll be more than happy to take a look at any specific use case I might've missed.
Explicit choices
The stable ID (F007D354) is used for all non-debug builds, consistent with jellyfin-web's default. The unstable ID (6F511C87) is declared in the same enum for future use when testing unreleased receiver changes, but is not referenced in any active code path in this PR.
JellyfinCastReceiverIDcontains magic strings that must match Google's Cast application registry and jellyfin-web's values exactly. If they drift, the app builds and runs silently but Cast fails on device with no compiler or runtime signal. The tests act as a human-review tripwire:stableReceiverIDMatchesKnownValuebreaks loudly if either ID changes, forcing a conscious check against upstream before updating.Phase 1 is infrastructure only. A reviewer running a release-equivalent build should see no Cast-related screens. UI (device picker, Cast button) comes in Phase 2 after the manager-proxy spine is exercised.
Future phases' PRs (on my fork atm, will open them one by one in the official repo as we go):