Skip to content

General Cleanup | ChevronButton & Deprecations#2017

Merged
LePips merged 2 commits into
jellyfin:mainfrom
LePips:cleanup
May 16, 2026
Merged

General Cleanup | ChevronButton & Deprecations#2017
LePips merged 2 commits into
jellyfin:mainfrom
LePips:cleanup

Conversation

@LePips

@LePips LePips commented May 16, 2026

Copy link
Copy Markdown
Member

In preparation of progressively bringing work over from #1752.

  • Cleans up ChevronButton
  • Lots of other cleanup of dead code, my deprecations, and inits

@LePips LePips requested a review from JPKribs May 16, 2026 16:26
@LePips LePips enabled auto-merge (squash) May 16, 2026 16:26
@JPKribs JPKribs added developer Alters the developer experience iOS Impacts iOS or iPadOS tvOS Impacts tvOS labels May 16, 2026

@JPKribs JPKribs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested and works as expected trying to go through all the impacted areas. 1 minor visual change I wanted to bring up in case it wasn't intentional. 1 historical tvOS bug that doesn't need to be changes here but is a touched component so just FYI.

Comment thread Shared/Components/ChevronButton.swift

@JPKribs JPKribs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Renamed the PR just so it's a bit more distinct. Primarily to make the final release post more descriptive.

@LePips LePips merged commit a9a6081 into jellyfin:main May 16, 2026
4 checks passed
@JPKribs JPKribs changed the title Cleanup General Cleanup | ChevronButton & Deprecations May 16, 2026
@LePips LePips deleted the cleanup branch May 20, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer Alters the developer experience iOS Impacts iOS or iPadOS tvOS Impacts tvOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants