Generic Paging Libraries#2047
Draft
LePips wants to merge 9 commits into
Draft
Conversation
JPKribs
added
developer
# Conflicts: # Shared/Objects/Libraries/ChannelLibrary.swift # Shared/Objects/Libraries/CountryLibrary.swift # Shared/Objects/Libraries/CultureLibrary.swift # Shared/ViewModels/AdminDashboard/ServerActivityViewModel.swift # Shared/ViewModels/HomeViewModel.swift # Shared/ViewModels/ItemAdministration/RemoteImageInfoViewModel.swift # Shared/ViewModels/ItemViewModel/ItemViewModel.swift # Shared/ViewModels/ItemViewModel/SeasonItemViewModel.swift # Shared/ViewModels/LibraryViewModel/ItemLibraryViewModel.swift # Shared/ViewModels/LibraryViewModel/LatestInLibraryViewModel.swift # Shared/ViewModels/LibraryViewModel/NextUpLibraryViewModel.swift # Shared/ViewModels/LibraryViewModel/RecentlyAddedViewModel.swift # Shared/ViewModels/Localization/ParentalRatingsViewModel.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Break out of library work in #1752.
Libraries are now generically defined by their data source, while the actual paging and element state is owned by the object over the library. The mutable "environment" that a library may want is defined by its own
Environmentobject.