Feature - Enhancements to the quick channel changer/chapter popup overlay#5447
Feature - Enhancements to the quick channel changer/chapter popup overlay#5447WizardOfYendor1 wants to merge 1 commit into
Conversation
ab7d8ad to
dd2f92d
Compare
ab8df2a to
67ae691
Compare
- add circular scrolling for quick channel and chapter popups - show favorite and recording indicators on channel cards - replace the static popup header with program title, episode metadata, and description with debounced updates - add a focused channel-card border and update the popup layout - preserve the focused channel across refreshes and long-running playback - harden popup row positioning, adapter lifecycle, and focus trapping - remove noisy logging and add null/edge-case guards
67ae691 to
cc23399
Compare
|
Housekeeping change: I squashed the commits so the history is less polluted. I merged in another change that added the recording indicator to the channel card, as it seemed to "go with" the other changes (like favorite icon). |
|
Feels off topic for this PR, for the live tv change, I wonder if you can include this idea as well #4537 |
Judging by my other PRs that were closed; I'm doubting any new enhancement PRs will be entertained (including this one) until the new rewrite is further along. I do have a new "greenfield" (i.e. written from scratch) of a compose livetv implementation for a stand alone jellyfin android tv client I've been working on. I may look at other clients out there and see if I can refactor it for them (presuming they want it) but it still needs a lot of work . If so, I'll work in your suggestion. Thanks. |



Enhancements to the quick channel changer popup overlay and to chapter overlay for library content (movies etc) to a lesser degree.
Left D-Pad focus boundary fix
Pressing left on the first channel/chapter card no longer lets focus escape the overlay (though improbable to encounter with the circular scrolling). This is also addressed separately in PR that fixes this issue without these changes/circular scrolling: Fix left D-Pad focus "escape" on channel and chapter display overlay #5413
Favorite heart icon on channel cards
A red heart icon now appears in the top-left corner of any channel card where the user has marked the channel as a favorite.
Add recording indicators in upper right of the channel cards.
Circular (carousel) scrolling
The channel list wraps around — scrolling past the last channel loops back to the first, and vice versa.
Implemented via a new CircularObjectAdapter that reports a "virtual item" count (realSize × 1,000). This is probably much larger than needs to be but there's no harm that I can see (it's not "preloaded" etc - per se). The overlay pre-positions to the correct virtual index when opening.
Program description above channel cards
When the quick channel overlay is open, the currently-focused channel's program title and description (overview) appears in a reserved 2-line text area above the cards.
The text updates with a 200ms debounce while scrolling to avoid distracting text "flicker".
Required adding ItemFields.OVERVIEW to the getLiveTvChannels API call to actually fetch the data.
Focus border on channel cards
The currently-focused channel card gets a thin white border so it's clearly visible. Implemented as a channel_card_background.xml. If this UI element were to be used in other places (chapter cards etc), I would probably implement this differently.
Tested in emulator, fire cube and nvidia shield. There are some "complimentary" changes in various other PRs that I didn't cherry pick into this but I have, and always have, merged all my branches/PRs together into an integration branch to test they will all co-exist. However, depending on merge order (if any), it's possible merge conflicts may arise. This one should be last if merged.
Code assistance
Claude Opus/Sonnet and Codex used mostly for code reviews but also investigating ideas/approaches. Used in some places for coding (agent mode) when issues arose.