Skip to content

Fix for audio and subtitle auto selection from previous media#5644

Open
BlackstormFirst wants to merge 7 commits into
jellyfin:masterfrom
BlackstormFirst:fix-audio-sub-auto-selection-from-previous-media
Open

Fix for audio and subtitle auto selection from previous media#5644
BlackstormFirst wants to merge 7 commits into
jellyfin:masterfrom
BlackstormFirst:fix-audio-sub-auto-selection-from-previous-media

Conversation

@BlackstormFirst

@BlackstormFirst BlackstormFirst commented Jun 11, 2026

Copy link
Copy Markdown

Changes:

  • Audio verification of the previous media is no longer limited to just the language but also checks the codec.
    If the same codec isn't found, then the selection reverts to language only.

  • Subtitle verification is no longer limited to just the language. It now checks the Title, Codec, Tag (forced or not), and finally the language.
    If the subtitles don't exactly match, it performs a fallback of Codec/Tag/Language, then if necessary another on Tag/Language, and finally a last one if needed on language only, as is currently the case for the latter.

Code assistance:
Android Studio (without AI)

Issues:
Fix: #5636

@BotBlake

Copy link
Copy Markdown
Member

Hi there!
Congratulations on opening your first PR 🎉

Note that we have a Pull-Request Template that needs to be filled in. That should have been loaded automatically when you created the PR on GitHub.

Could you please change the PR description so it matched the following format:

Changes
Describe your changes here in 1-5 sentences.

Code assistance
If code assistance was used, describe how it contributed
e.g., code generated by LLM, explanation of code base, debugging guidance.

Issues
Tag any issues that this PR solves here.
ex. Fixes #

Kind regards

@BlackstormFirst

Copy link
Copy Markdown
Author

Done ^^
Enjoy!

@BlackstormFirst

Copy link
Copy Markdown
Author

I will don't touch this branch anymore.
But i will add the management of some additional subtitle indicators in another one (SDH, AudioDescription...) to complete the selections capabilites.

@BotBlake

Copy link
Copy Markdown
Member

Hi there!

Thank you for keeping your pull request up to date.

Please note that merging master into your feature branch is usually not necessary. Each merge commit generates notifications for everyone subscribed to the pull request and can make the commit history more difficult to follow.

In general, please only merge master into your branch when:

  • Git reports merge conflicts that need to be resolved, or
  • there is another specific reason that requires the latest changes from master.
  • you want to re-trigger the CI manually

If GitHub indicates that the branch can be updated or merged automatically, there is typically no need to create a merge commit from master.

Since master changes frequently, avoiding unnecessary merges helps keep pull requests easier to review and reduces notification noise for maintainers and contributors alike.

Thank you for your understanding and for your contribution.

Kind regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect subtitle and audio auto selection from previous media

2 participants