Skip to content

Commit 3134050

Browse files
committed
fix HTMLInputElement errors
1 parent 0549c22 commit 3134050

1 file changed

Lines changed: 10 additions & 20 deletions

File tree

  • src/apps/legacy/controllers/session/login

src/apps/legacy/controllers/session/login/index.js

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ function authenticateUserByName(page, apiClient, url, username, password) {
5050
},
5151
/** @param {{ status: number }} response */
5252
function (response) {
53-
// @ts-expect-error
54-
page.querySelector('#txtManualPassword').value = '';
53+
/** @type {HTMLInputElement} */ (page.querySelector('#txtManualPassword')).value = '';
5554
loading.hide();
5655

5756
const UnauthorizedOrForbidden = [401, 403];
@@ -156,18 +155,15 @@ function onLoginSuccessful(id, accessToken, apiClient, url) {
156155
* @param {boolean?} [focusPassword]
157156
*/
158157
function showManualForm(context, showCancel, focusPassword) {
159-
// @ts-expect-error
160-
context.querySelector('.chkRememberLogin').checked = appSettings.enableAutoLogin();
158+
/** @type {HTMLInputElement}*/ (context.querySelector('.chkRememberLogin')).checked = appSettings.enableAutoLogin();
161159
/** @type {Element} */ (context.querySelector('.manualLoginForm')).classList.remove('hide');
162160
/** @type {Element} */ (context.querySelector('.visualLoginForm')).classList.add('hide');
163161
/** @type {Element} */ (context.querySelector('.btnManual')).classList.add('hide');
164162

165163
if (focusPassword) {
166-
// @ts-expect-error
167-
context.querySelector('#txtManualPassword').focus();
164+
/** @type {HTMLInputElement}*/ (context.querySelector('#txtManualPassword')).focus();
168165
} else {
169-
// @ts-expect-error
170-
context.querySelector('#txtManualName').focus();
166+
/** @type {HTMLInputElement}*/ (context.querySelector('#txtManualName')).focus();
171167
}
172168

173169
if (showCancel) {
@@ -285,23 +281,19 @@ export default function (view, params) {
285281
const haspw = cardContent.getAttribute('data-haspw');
286282

287283
if (id === 'manual') {
288-
// @ts-expect-error
289-
context.querySelector('#txtManualName').value = '';
284+
/** @type {HTMLInputElement} */ (context.querySelector('#txtManualName')).value = '';
290285
showManualForm(context, true);
291286
} else if (haspw == 'false') {
292287
authenticateUserByName(context, getApiClient(), getTargetUrl(), name, '');
293288
} else {
294-
// @ts-expect-error
295-
context.querySelector('#txtManualName').value = name;
296-
// @ts-expect-error
297-
context.querySelector('#txtManualPassword').value = '';
289+
/** @type {HTMLInputElement} */ (context.querySelector('#txtManualName')).value = name;
290+
/** @type {HTMLInputElement} */ (context.querySelector('#txtManualPassword')).value = '';
298291
showManualForm(context, true, true);
299292
}
300293
}
301294
});
302295
/** @type {Element} */ (view.querySelector('.manualLoginForm')).addEventListener('submit', function (e) {
303-
// @ts-expect-error
304-
appSettings.enableAutoLogin(view.querySelector('.chkRememberLogin').checked);
296+
appSettings.enableAutoLogin(/** @type {HTMLInputElement} */ (view.querySelector('.chkRememberLogin')).checked);
305297
authenticateUserByName(
306298
view,
307299
getApiClient(),
@@ -321,8 +313,7 @@ export default function (view, params) {
321313
return false;
322314
});
323315
/** @type {Element} */ (view.querySelector('.btnManual')).addEventListener('click', function () {
324-
// @ts-expect-error
325-
view.querySelector('#txtManualName').value = '';
316+
/** @type {HTMLInputElement} */ (view.querySelector('#txtManualName')).value = '';
326317
showManualForm(view, true);
327318
});
328319
/** @type {Element} */ (view.querySelector('.btnSelectServer')).addEventListener('click', function () {
@@ -354,8 +345,7 @@ export default function (view, params) {
354345
showVisualForm();
355346
loadUserList(view, apiClient, users);
356347
} else {
357-
// @ts-expect-error
358-
view.querySelector('#txtManualName').value = '';
348+
/** @type {HTMLInputElement} */ (view.querySelector('#txtManualName')).value = '';
359349
showManualForm(view, false, false);
360350
}
361351
}).catch().then(function () {

0 commit comments

Comments
 (0)