migrate comics and PDFs to new BookOsd component#8004
Open
dkanada wants to merge 4 commits into
Open
Conversation
Collaborator
Cloudflare Pages deployment
|
This comment has been minimized.
This comment has been minimized.
jellyfin-bot
added
merge conflict
thornbill
added
enhancement
MBR-0001
reviewed
Jun 27, 2026
MBR-0001
left a comment
MBR-0001
left a comment
Member
There was a problem hiding this comment.
A few observations:
The new OSD for pdf hides/blocks the content at the top and bottom
Screencast_20260627_164313.webm
On the comic player this does not happen
Screencast_20260627_164451.webm
BUT, it seems dragging to change page does not work:
Screencast_20260627_164615.webm
MBR-0001
requested changes
Jul 12, 2026
MBR-0001
left a comment
MBR-0001
left a comment
Member
There was a problem hiding this comment.
Previously mentioned issues are resolved, now the pdf viewer is broken on mobile
Screencast_20260712_230255.webm
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
MBR-0001
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
PDF and comic players now use the BookOsd component with their existing subset of UI features.
Subsequent pull requests will focus on adding fullscreen everywhere, implementing a unified page indicator in React, and extracting book navigation controls into a global helper function for user customization.
Issues
None
Code Assistance
None