Show the server-provided name for plugin tuner types#8233
Closed
vk496 wants to merge 1 commit into
Closed
Conversation
The tuner device card resolves its title from a hardcoded type list and shows Unknown for any type not in it, including plugin-provided tuners. Use the name returned by the TunerHosts/Types endpoint, keeping the static list as a fallback.
|
Member
|
Please follow the pull request template. |
Author
|
Reopened as #8235 following the pull request template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The tuner device card resolves its title from a hardcoded type list (
getTunerName) and shows "Unknown" for any type not in it, including plugin-provided tuners. This uses the display name returned by theTunerHosts/Typesendpoint via a smalluseTunerHostTypeshook, keepinggetTunerNameas a fallback while the query loads.A plugin can register an
ITunerHost; it shows up by name in the "Add Tuner Device" dropdown, but once added the device card reads "Unknown". This makes the card match the dropdown.Motivating case: https://github.com/vk496/jellyfin-htsp-tuner
Issues
Part of jellyfin/jellyfin#17372. The guide provider list has the same limitation but needs a new API, proposed in jellyfin/jellyfin#17371.
Code assistance