Revert unix command to command to prevend breaking changes

[Roemer]

Revert an incompatible change from #118

[jglick]

docker-swarm-plugin/src/main/java/org/jenkinsci/plugins/docker/swarm/DockerSwarmAgentTemplate.java

Line 38 in ab8dd92

private String unixCommand;

must also be renamed to retain compatibility in $JENKINS_HOME/config.xml. (You can use @LocalData to test this sort of thing by the way.) configuration-as-code users on the other hand will need

docker-swarm-plugin/src/main/java/org/jenkinsci/plugins/docker/swarm/DockerSwarmAgentTemplate.java

Line 265 in ab8dd92

public String getUnixCommand() {

renamed to match the constructor parameter name.

As an aside, similar to https://www.jenkins.io/doc/developer/plugin-development/pipeline-integration/#constructor-vs-setters it is recommended to limit @DataBoundConstructor parameters to those fields which are obligatory (no sensible default could be provided), and use @DataBoundSetter for everything else. If you do this right, config.xml can avoid serializing fields unmodified from their default, and JCasC users will need only set interesting fields (and exporting JCasC YAML will display only those fields which were really edited).

[jglick]

By the way just

Suggested change

	<f:textarea value="${dockerSwarmAgentTemplate.command}" default="sh&#10;-cx&#10;curl --connect-timeout 20 --max-time 60 -o agent.jar $DOCKER_SWARM_PLUGIN_JENKINS_AGENT_JAR_URL &amp;&amp; java -classpath agent.jar hudson.remoting.jnlp.Main -headless -url $DOCKER_SWARM_PLUGIN_JENKINS_URL -noreconnect -workDir /tmp $DOCKER_SWARM_PLUGIN_JENKINS_AGENT_SECRET $DOCKER_SWARM_PLUGIN_JENKINS_AGENT_NAME"/>
	<f:textarea default="sh&#10;-cx&#10;curl --connect-timeout 20 --max-time 60 -o agent.jar $DOCKER_SWARM_PLUGIN_JENKINS_AGENT_JAR_URL &amp;&amp; java -classpath agent.jar hudson.remoting.jnlp.Main -headless -url $DOCKER_SWARM_PLUGIN_JENKINS_URL -noreconnect -workDir /tmp $DOCKER_SWARM_PLUGIN_JENKINS_AGENT_SECRET $DOCKER_SWARM_PLUGIN_JENKINS_AGENT_NAME"/>

should work (same for other properties): the point of the field attr on f:entry is that it takes care of the plumbing needed for config form round-trips so long as you are consistent in your naming.

[jglick]

Stalled?