Skip to content

Escape illegal '.' character before submitting data to ElasticSearch.#21

Open
ceilfors wants to merge 2 commits into
jenkinsci:masterfrom
ceilfors:period-fix
Open

Escape illegal '.' character before submitting data to ElasticSearch.#21
ceilfors wants to merge 2 commits into
jenkinsci:masterfrom
ceilfors:period-fix

Conversation

@ceilfors

@ceilfors ceilfors commented Jan 5, 2017

Copy link
Copy Markdown
Member

ElasticSearch is rejecting logstash-plugin data when an environment variable contains a '.' character. Specific problem encountered: When artifactory-plugin is used, the plugin will inject an environment variable called buildInfoConfig.propertiesFile.

ElasticSearch is rejecting logstash-plugin data when an environment variable contains a '.' character. Specific problem encountered: When artifactory-plugin is used, the plugin will inject an environment variable called buildInfoConfig.propertiesFile.
@jakub-bochenski

jakub-bochenski commented May 10, 2017

Copy link
Copy Markdown

@ceilfors I tried to reproduce the issue with 1.2.1, but I can't

I've set VARIABLE.WITH.DOT via EnvInject and I see an

"_source": {
  "data":  {
    "buildVariables": {
        "VARIABLE.WITH.DOT": "foo",

entry in ES

@ceilfors

ceilfors commented May 10, 2017 via email

Copy link
Copy Markdown
Member Author

@jakub-bochenski

Copy link
Copy Markdown

I think it worked in my setup because I'm actually using Logstash before the ES instance with the de_dot filter: https://www.elastic.co/blog/introducing-the-de_dot-filter

I think this is another reason for having a separate ES and Logstash indexer types instead of using the same for both

@jakub-bochenski jakub-bochenski mentioned this pull request Jul 3, 2017
@jakub-bochenski

Copy link
Copy Markdown

@mwinter69 I think we should add this to the logstash tcp backed? I don't think it was included in #59

@mwinter69

Copy link
Copy Markdown

No, but this PR here is for Elastic Search. I think it should be optional.

@jakub-bochenski

Copy link
Copy Markdown

uh, right sorry I mixed the two up

@mwinter69 mwinter69 mentioned this pull request Jul 5, 2018
@darxriggs

Copy link
Copy Markdown

Should this be closed as the author already moved on to other projects?

@jakub-bochenski

Copy link
Copy Markdown

The OP might have moved on, but the problem is still there. The challenge is to handle it while keeping it opt-in and without code duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants