Leaf-level physics: assemblies carry none; structure_* static - #7
Open
jensjebens wants to merge 2 commits into
Open
Leaf-level physics: assemblies carry none; structure_* static#7jensjebens wants to merge 2 commits into
jensjebens wants to merge 2 commits into
Conversation
Physics is an asset property of leaf components, not assemblies: - Remove the physics layer (and un-wire the physics sublayer) from the 9 environment ASSEMBLIES (lab_*). They were applying one coarse convex hull to the whole assembly's proxy geo, redundant with the per-component physics that composes from the setpieces they reference (and the source of the duplicate- prim parse bugs in alab_set01/lab_electronics01). - Make the 27 structure_* leaves (floor, walls, roof, doors, windows, bricks) STATIC colliders: strip PhysicsRigidBodyAPI from the root, keep CollisionAPI/MeshCollisionAPI. They were dynamic setpieces/props, so the whole room shell would have fallen under gravity. Loose setpieces/props stay dynamic. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…oard collision - Add PhysicsMassAPI + physics:density to every dynamic setpiece/prop layer. density = 1000 kg/m^3 * metersPerUnit^3 (= 0.001 at ALab cm scale), so Newton computes realistic masses instead of cm-scale auto-mass (~1e6x too big -- e.g. a 37-tonne circuit board) that left bodies effectively immovable. Verified mass: tool_screw ~0.35 g, bottle cap ~1.2 g, bench seat ~14 kg. - Rewrite the 10 proc_dev_circuit_board_* layers: collision was authored on the point-instancer component geometry => Newton mass 0 => static. Retarget to proxyGeo/mesh_0 (convexHull). Verified: board mass ~0.037 kg and it falls. Static structure_* (no rigid body) and assemblies (no physics) untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Physics belongs on leaf components. (A) Removed physics from the 9 environment assemblies (redundant coarse proxy; also the dup-prim bug source) -- physics composes from referenced setpieces. (B) Made the 27 structure_* leaves static colliders (they were dynamic, so the room shell would fall). Loose setpieces/props stay dynamic. Supersedes #6 for alab_set01/lab_electronics01 (those assembly layers are now deleted).