This repository was archived by the owner on Jul 26, 2026. It is now read-only.
fix: wrong import for '../sfcc-globals' - #118
Merged
Merged
Conversation
jenssimon
approved these changes
Mar 5, 2026
Owner
|
@rge-dS Thanks for your contribution. Totally missed that piece. But a small question besides that: I ask because I don't know how urgent it is to add ESLint > 8 (flat config) support to the plugin. |
Contributor
Author
|
Hi @jenssimon sorry for the late reply. Thank you for maintaining these configs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the require path for
sfccGlobalswas still pointing to../sfccGlobalsinstead of../sfcc-globals, which was causing a module resolution error. I've updated it to match the actual filename.Thanks for maintaining this package!