Skip to content
This repository was archived by the owner on Jul 26, 2026. It is now read-only.

fix: wrong import for '../sfcc-globals' - #118

Merged
jenssimon merged 1 commit into
jenssimon:mainfrom
rge-dS:patch-1
Mar 5, 2026
Merged

fix: wrong import for '../sfcc-globals'#118
jenssimon merged 1 commit into
jenssimon:mainfrom
rge-dS:patch-1

Conversation

@rge-dS

@rge-dS rge-dS commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

I noticed the require path for sfccGlobals was still pointing to ../sfccGlobals instead of ../sfcc-globals, which was causing a module resolution error. I've updated it to match the actual filename.
Thanks for maintaining this package!

@jenssimon jenssimon changed the title fix error: Cannot find module '../sfccGlobals' fix: wrong import for '../sfcc-globals' Mar 5, 2026
@jenssimon
jenssimon merged commit dba07e1 into jenssimon:main Mar 5, 2026
5 checks passed
@jenssimon

Copy link
Copy Markdown
Owner

@rge-dS Thanks for your contribution.

Totally missed that piece.

But a small question besides that:
On which version of ESLint do you use this plugin?

I ask because I don't know how urgent it is to add ESLint > 8 (flat config) support to the plugin.

@rge-dS

rge-dS commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

Hi @jenssimon sorry for the late reply.
We are using currently Eslint 8.57.1 and upgraded recently to Node 18 because of the latest SFRA upgrade. (So upgrading to Eslint 9 is now possible).
I would say it would be helpful if you have the time to add flat config support (since also eslint-config-base has already flat config support), but it's not very urgent.

Thank you for maintaining these configs!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants