Added naStrings option to 'null_to_na()' and precessors#318
Open
joachim-gassen wants to merge 2 commits intojeroen:masterfrom
Open
Added naStrings option to 'null_to_na()' and precessors#318joachim-gassen wants to merge 2 commits intojeroen:masterfrom
joachim-gassen wants to merge 2 commits intojeroen:masterfrom
Conversation
jeroen
force-pushed
the
master
branch
8 times, most recently
from
e43a8f6 to
89a3e99
Compare
|
@jeroen, any plans to accept this into the codebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to address #98 and #314. I was also affected by this corner case (downloading of Google Trends data for Namibia with the {gtrendsR} package failing systematically). As it is likely to regularly affect data from/about Namibia (ISO2c of Namibia being "NA") and I happen to like the country and its people I thought that I whip something up.
The PR is written in a way that it does/should not affect the default behavior of the package. It includes some tests, passes the existing ones and
R cmd checkgoes through but I am virtually certain that I have overlooked something.So use as an inspiration or feel free to ignore. In any case: Thank you very much for this extremely important package!
Joachim