Add pending task capability for opening pull requests#4370
Add pending task capability for opening pull requests#4370ChrisMcD1 wants to merge 6 commits intojesseduffield:masterfrom
Conversation
|
@ChrisMcD1 I talked to @jesseduffield about this, and we were wondering whether the complexity of this approach is worth it. Also, we are not sure that the proposed UX is the best one. It might be better (and simpler) to include pushing the branch in the "open PR" command. After all, is there ever a situation where you want to open a PR without pushing your branch first? The way I think this would work is this: you don't push your branch, but press
I am very unfamiliar with the shift-O command, and to be honest I can barely tell what all the options in that menu mean; I only use What are your thoughts on this? |
|
@stefanhaller Yeah, I can agree with exclusion based on the complexity. I'll poke around the ideas mentioned to augment the open PR button, they sound quite promising. On the |
Implements #4339.
Creates the new concept of a
PendingTask, where gocui is waiting for some action to complete before beginning the real work. In this application, the PendingTask is watching WaitGroup that records that a certain branch is being pushed. Once the branch is finished being pushed, it will automatically start the open pull request command. While waiting on the pending phase of the task, it can be cancelled with the global<escape>keybinding. (I'm not positive where the pending tasks should go in that sequence of cancelling. Perhaps they should be later in that file)The behavior Demo and ASYNC's Then might also need some more tweaks, I'm not sure about that.
go generate ./...)