Conversation
Add validation to additional fields to prevent later errors in the upload process. Improved validation logic to ensure that falsy fields do not properly trigger validation when they are indeed valid. This happened when importing from XLSX and the field type was number with a value of "0". resolves #1263
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for editing query and saved query names in the query history modal by adding and refining input validations. Key changes include:
- Adding length validations and custom error messages for several text fields.
- Adjusting regex-based validations by removing explicit empty-value checks in favor of relying on the required property.
- Updating error message wording for numerical fields to clarify bounds.
Comments suppressed due to low confidence (1)
libs/shared/ui-core/src/create-fields/create-fields-utils.tsx:199
- [nitpick] The updated error messages change the phrasing from specifying a range to using 'not exceed'. Ensure that the documentation and user guidance reflect these updated constraints and phrasing for clarity.
return 'Must not exceed 255 characters';
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature adds support for editing query history name and saved query names from the query history modal
resolves #1255