Skip to content

Make it compatible with latest version of Flutter Sdk and JAVA version#1368

Open
pintusingh28 wants to merge 3 commits intojhomlala:masterfrom
pintusingh28:master
Open

Make it compatible with latest version of Flutter Sdk and JAVA version#1368
pintusingh28 wants to merge 3 commits intojhomlala:masterfrom
pintusingh28:master

Conversation

@pintusingh28
Copy link
Copy Markdown

I have made the library to compatible with latest versions of Android Studio and Flutter sdk:

Changelog:

  • Added android namespace
  • Updated Java compatibility version
  • Replaced hashValues with Object.hash method

[REMOVED] removed invalid lint `invalid_dependency`
[UPDATED] updated java and kotlin version
@pintusingh28 pintusingh28 marked this pull request as draft December 18, 2024 16:22
@pintusingh28 pintusingh28 marked this pull request as ready for review December 18, 2024 16:22
@pintusingh28
Copy link
Copy Markdown
Author

#1359 #1361

Copy link
Copy Markdown
Author

@pintusingh28 pintusingh28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed and tested all the changes.

@inamhusain
Copy link
Copy Markdown

when it will merged to main?

@pintusingh28
Copy link
Copy Markdown
Author

when it will merged to main?

@inamhusain Waiting for repo owner to accept pull request.

@lazytesting
Copy link
Copy Markdown

@jhomlala any news on this?

@nateshmbhat
Copy link
Copy Markdown

Hello @pintusingh28 . Thanks for raising this PR. Unfortunately the developer of better player hasn't been getting enough time to work and maintain this project.

So have forked and maintaining this project as awesome_video_player here (https://pub.dev/packages/awesome_video_player)

Would be wonderful if you can raise this PR there 🎊 🥳
https://github.com/nateshmbhat/awesome_video_player

@pintusingh28
Copy link
Copy Markdown
Author

@nateshmbhat You GitHub repo seems private, you need to keep it public, So I can create PR

@nateshmbhat
Copy link
Copy Markdown

@nateshmbhat You GitHub repo seems private, you need to keep it public, So I can create PR

Oops that was by mistake. Have fixed it now 🙏🏻 Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants