Fix remove package="com.jhomlala.better_player" from the source androidmanifest.xml Error #1392
Open
malawadgosi wants to merge 2 commits intojhomlala:masterfrom
Open
Fix remove package="com.jhomlala.better_player" from the source androidmanifest.xml Error #1392malawadgosi wants to merge 2 commits intojhomlala:masterfrom
malawadgosi wants to merge 2 commits intojhomlala:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
### [Fix] Remove package="com.jhomlala.better_player" from AndroidManifest.xml
Issue
The AndroidManifest.xml file in the better_player Flutter package contains package="com.jhomlala.better_player", which is an outdated way of defining the application package name. This causes build failures in recent versions of Flutter and Android projects.
Fix
Removed package="com.jhomlala.better_player" from AndroidManifest.xml.
Ensured that the manifest aligns with modern Android project structure, which inherits the package name from AndroidManifest.xml in the main app module.
Impact
Fixes the build issue preventing applications from compiling.
Ensures compatibility with the latest Flutter and Android build systems.
Testing
Successfully built and ran a sample Flutter project using better_player after applying the fix.
References
Flutter Android Manifest Documentation